dev/core#2488 - When setting default optionValue, limit query to specified domain

[colemanw]

Overview

Fixes issue https://lab.civicrm.org/dev/core/-/issues/2488 by constraining query by domain when bulk-updating the default optionValue in an optionGroup.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Testing from martin.w on gitlab:

I've merged your changes to my CRM/Core/BAO/OptionValue.php and tried a couple manual tests which passed:

• OptionValue.create option_group_id=from_email_address is_default=1 ... for a specific domain ==> adds a new option_value record which becomes the default for the specified domain only. All other domain is_default values are unchanged.
• OptionValue.create id={prior_record_ID} is_default=1 for the same domain ==> The record with id={prior_record_ID} becomes the is_default = 1 record for the specified domain. All other domain is_default values are unchanged.

Looks all good to go to me. Incidentally, I tested with cv api (i.e. APIv3) since that's what I had previously scripted.

[eileenmcnaughton]

Merging based on gitlab feedback