Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-notice fix on serialized setting #19969

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

E-notice fix on serialized setting

Before

E-notice when using the setting page trait to render a settings form in an extension with a serialized field and declaring field defaults as an array

After

poof

Technical Details

We do actually support settings declaring defaults for a serialized field as an array rather
than as a serialised string. However, this setting form, if used, will display an
e-notice in that case as it will still try to unserialize - this adds a simple check first

Comments

We do actually support settings declaring defaults for a serialized field as an array rather
than as a serialised string. However, this setting form, if used, will display an
e-notice in that case as it will still try to unserialize - this adds a simple check first
@civibot
Copy link

civibot bot commented Apr 5, 2021

(Standard links)

@civibot civibot bot added the master label Apr 5, 2021
@seamuslee001
Copy link
Contributor

This looks fine to me

@seamuslee001 seamuslee001 merged commit 6b0cbfa into civicrm:master Apr 7, 2021
@seamuslee001 seamuslee001 deleted the settingbag branch April 7, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants