Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2164 Proposed fix for CORE-2164 #19963

Merged
merged 1 commit into from
Apr 3, 2021

Conversation

bjendres
Copy link
Contributor

@bjendres bjendres commented Apr 3, 2021

Overview

Patch for CORE-2146. Quote from there:

Export tmp tables are created with varchar(16) for T_BOOLEAN types. This may be sufficient for the short-worded language
English but if translated we get longer export values. So this should be 32 or more

Before

Export of all contact data with at least one contact with an email on hold in German l10n crashes with Data too long exception.

After

Export works again.

Technical Details

This is a re-implementation of @wannesderoy's #18920

@civibot
Copy link

civibot bot commented Apr 3, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor

thanks @bjendres - the trick is to do

git pull --rebase

before you attempt to do a cleanup rebase (I actually use that command instead of git pull close to 100% of the time)

@eileenmcnaughton eileenmcnaughton merged commit 56233cb into civicrm:master Apr 3, 2021
@eileenmcnaughton eileenmcnaughton changed the title Proposed fix for CORE-2164 dev/core#2164 Proposed fix for CORE-2164 Apr 3, 2021
@eileenmcnaughton
Copy link
Contributor

@bjendres also note the dev/core#2164 syntax caused the github / gitlab link - there is a place you can copy that format in gitlab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants