Fix for dev/core#2503

[jaapjansma]

Overview

CiviReport does not localize custom fields of type Money.

Before

Reports did not localize the display value of custom fields of type Money.

After

Reports localizes the display value of custom fields of type Money.

Technical Details

This PR sets the field type in the report to T_FLOAT instead of T_MONEY.
This will do two things:

1. CRM_Core_BAO_CustomField::displayValue is called in alterCustomDataDisplay which results in correctly localize the value
2. In the report template the smarty modifier |crmMoney is called for money fields. Setting it to T_FLOAT will prevent this being called for an already localized custom money field.

Comments

See as well: https://lab.civicrm.org/dev/core/-/issues/2503

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Thanks @jaapjansma - I'm going to merge this based on your analysis / testing as I can't see it impacting outside of what you have tested - I appreciate you working on these