dev/financial#172 - Warning when saving a contribution with a recognition date

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/financial/-/issues/172

Before

1. Turn on deferred revenue in civicontribute settings.
2. Create a contribution and fill in the recognition date.

Warning: array_filter() expects parameter 1 to be array, string given in CRM_Contribute_Form_Contribution::formRule() (line 914 of /home/jenkins/bknix-dfl/build/core-19940-91yka/web/sites/all/modules/civicrm/CRM/Contribute/Form/Contribution.php).
    Warning: count(): Parameter must be an array or an object that implements Countable in CRM_Contribute_Form_Contribution::formRule() (line 914 of /home/jenkins/bknix-dfl/build/core-19940-91yka/web/sites/all/modules/civicrm/CRM/Contribute/Form/Contribution.php).

After

Ok

Technical Details

I think this is leftover from datepicker switches? It's checking that the date has a year and a month, but it's not separate components now.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I agree