dev/core#2486 Add entity financial trxn #19932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
reviewed
Mar 29, 2021
| public static function entityTables(): array { | ||
| return [ | ||
| 'civicrm_contribution' => ts('Contribution'), | ||
| 'civicrm_financial_item' => ts('Financial Item'), |
There was a problem hiding this comment.
I think this is missing the optionValue table. It's important to get all of them especially because the v3 api will validate against these options, and without that option, civicrm_api3('EntityFinancialTrxn', 'create', ['entity_table' => 'civicrm_option_value'] ...); would throw an error.
|
@colemanw no - that's the other PR - this table doesn't join to option value |
|
Oh, ok. I can't keep them all straight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/core#2486 Add entity financial trxn
Before
A big black nothing
After
Tada
Technical Details
Comments