dev/core#2486 Add v4 batch api

[eileenmcnaughton]

Overview

dev/core#2486 Add v4 batch api

Before

the abyss

After

tada

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@eileenmcnaughton why are you moving this file? i'm not sure if it will then be picked up because the class name doesn't match the file name then.

[eileenmcnaughton]

ug that was an opps / ide trying to fix up psr issues

[eileenmcnaughton]

@seamuslee001 fixed

[eileenmcnaughton]

This failed because 'title' is not required but 'kinda is' in the BAO

I made it required - but I haven't done the upgrade script as it would conflict with #19512

In addition I'm leaning around 80% towards using a hash as a default for title in the BAO since I feel like batches don't super need meaningful titles

What do you think @seamuslee001 @colemanw - this is the line

civicrm-core/CRM/Batch/BAO/Batch.php

Line 46 in 3e42836

$params['name'] = CRM_Utils_String::titleToVar($params['title']);

[colemanw]

I think supplying a random string as name is fine if ommitted.

[eileenmcnaughton]

@colemanw OK it will now do 'batch_ref' + a random number