Add entity financial account bridge entity

[eileenmcnaughton]

Overview

Add entity financial account bridge entity

Before

Bridge entity not described

After

Now it is

Technical Details

@colemanw I've been digging around & can see that this is required -but is not in itself enough - ie

What else is needed?

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

@eileenmcnaughton if the table doesn't contain exactly 2 FKs, then you have to add an annotation to say which 2 entities it is supposed to link together. Like this:

civicrm-core/Civi/Api4/RelationshipCache.php

Line 26 in 9f338c0

* @bridge near_contact_id far_contact_id

[eileenmcnaughton]

@colemanw ah - so there is an entity_id -> entity_table

In addition I think the account_relationship option values would work rather like the record_type_id in activity contact table (ie they are almost like different entitiies)

[colemanw]

@eileenmcnaughton if you want the AccountRelationship field automatically shown when adding join in searchKit (like relationship type id is shown for related contacts or activity contact type is shown for activities) do this:

Suggested change

	*
	* @ui_join_filters account_relationship

[eileenmcnaughton]

@colemanw I've pushed that up - although note the whole thing doesn't work atm

[colemanw]

I see the problem @eileenmcnaughton. The field entity_table doesn't have any pseudoconstant, therefore the joiner has no idea what possible tables it can join to.

[eileenmcnaughton]

@colemanw right - the only entity that does have one is entity_tag I guess.
The possibilities are

• financial_type
• payment_processor
• option_value.value WHERE option_group_id:name = Payment Instrument

(that last doesn't help!)

[colemanw]

More than just entityTag, there's quite a few entity_table fields with pseudoconstants. It's pretty much required to get a bridge join to work.
I don't understand that last one - how does that point to a table name?

[eileenmcnaughton]

@colemanw here is the latter part of the table

The entity_id actually holds the id not the value it seems - which is a nasty non standard use of the option_value table but might be helpful here

[colemanw]

Yes that is actually helpful. So our pseudoconstant list just needs to contain 3 options and we should be good to go, at least as far as SearchKit is concerned.

[eileenmcnaughton]

@colemanw ok - that seemed to work - let's see how jenkins gets on

[colemanw]

I don't think the test failure is related but retest this please just to be sure.

[eileenmcnaughton]

@colemanw sadly it is - it's the contribution recur entity defaults tripping us up (AGAIN) - I added this
#19934

[colemanw]

@eileenmcnaughton I've merged the other. Can you rebase this pls?

[eileenmcnaughton]

@colemanw done - lets see how it goes!

[eileenmcnaughton]

@colemanw yep passing now!

[colemanw]

Looks great!