[REF] [Towards membership api] Cleanup access to payment_processor_id

[eileenmcnaughton]

Overview

[REF] [Towards membership api] Cleanup access to payment_processor_id

Before

Variable passed around

After

Variable fetched

Technical Details

@monishdeb I've put up separate PRs for readability but the prs towards membership api should be all testable together https://github.com/civicrm/civicrm-core/pulls?q=is%3Aopen+is%3Apr+author%3Aeileenmcnaughton+membership (at some point they will get too interdependent but we are not there yet)

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[monishdeb]

r-run passed. Reviewed patch, looks good. Merging now.

[eileenmcnaughton]

thanks @monishdeb - note that all the membership ones apart from the WIP one you should be able to r-run together