[REF] [Search-kit-actions] Cleanup around contribution pdf common #19904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
I can't see any way to call this over than from search so I think this is from copy & paste from invoice which DOES support id
the DAO throws them away - so we are better just to take the obscure performance hit until we can do other refactoring
With this change made we are ready to start exposing some actions to search kit
|
@demeritcowboy @jitendrapurohit @monishdeb - if any of you have a chance to r-run this getting it merged will remove an obstacle to getting more actions available in search kit |
|
Tested in local, esp on Contribution task actions like print receipt, print selected rows etc. didn't encounter any regression/breakage. Also like orientation of centralising the code in respective fns. Overall PR looks good to me. Merging now |
|
thanks @monishdeb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Cleanup around contribution pdf common
Before
Shared contribution task code is complex due to handling for soft credits the pdf class
After
Handling for soft credits moved to the pdf class
Technical Details
@monishdeb @seamuslee001 @colemanw once this is merged we can start to actually expose actions to search-kit
Comments