Only call getGroupACLRoles if contactID is present #19894
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Only call getGroupACLRoles if contactID is present
Before
I don't see how the query could ever return anything if contactID is not a number
After
Not called if contactID is not a number
Technical Details
@seamuslee001 I kept this small as it needs a bit of thinking through but I can't see a reason why it would make sense to call the function with no contactID
Comments