Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only call getGroupACLRoles if contactID is present #19894

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Only call getGroupACLRoles if contactID is present

Before

I don't see how the query could ever return anything if contactID is not a number

After

Not called if contactID is not a number

Technical Details

@seamuslee001 I kept this small as it needs a bit of thinking through but I can't see a reason why it would make sense to call the function with no contactID

Comments

@civibot
Copy link

civibot bot commented Mar 24, 2021

(Standard links)

@civibot civibot bot added the master label Mar 24, 2021
@seamuslee001
Copy link
Contributor

@eileenmcnaughton if the user is Anonymous then what would have been $contact_id here 0?

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 that's why I moved that part back out of the function & to the calling function

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 did ^^ answer your question?

@seamuslee001
Copy link
Contributor

yep i think this is ok merging

@seamuslee001 seamuslee001 merged commit fdf79a6 into civicrm:master Mar 31, 2021
@seamuslee001 seamuslee001 deleted the acl branch March 31, 2021 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants