Fix for dev/drupal#158

[jaapjansma]

Overview

This fixes an annoying bug in Drupal 8 and Drupal 9 where Drupal does not recognize any urls defined in a newly installed extension.

The work aorund is to clear the drupal caches.

Before

After installing an extension drupal will return Page not found when going to a page defined in the extension.

After

After installing an extension drupal will show the content when going to a page defined in the extension.

Technical Details

There is a little hack needed, we need to check whether the Drupal class is available and if so we assume we are in drupal 8/9 and we rebuild the router.

Comments

I am not completely sure whether this is the right place to fix this.

See https://lab.civicrm.org/dev/drupal/-/issues/158 and https://lab.civicrm.org/dev/drupal/-/issues/37

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[homotechsual]

I think we should be doing \Drupal\Core\Cache\Cache::invalidateTags(['route_match']) since it has a lower performance impact. The rebuild() option is a bit like using a sledgehammer, it rebuilds every single route including core provided ones. Rebuilding the route_match tag only clears out non-static routes.

https://drupal.stackexchange.com/questions/288321/is-there-a-way-to-partially-rebuild-the-router-or-invalidate-a-route-cache

[seamuslee001]

I agree Mikey but also I'm kind of a little nervous / concerned about having CMS specific code here I'm wondering if we need to create a function on the CRM_Utils_System_x classes instead?

[homotechsual]

I agree Mikey but also I'm kind of a little nervous / concerned about having CMS specific code here I'm wondering if we need to create a function on the CRM_Utils_System_x classes instead?

I agree, I'd like us to do this when an extension is enabled ideally since that's when we need to do it, that and ideally when rebuilding Civi's menu.

[demeritcowboy]

Thanks @jaapjansma for giving this a kick. It seems like the decision now is just where the call should go. My vote is for the other PR simply because this here would get called on every menu item not just related to extensions.

[jaapjansma]

Fixed by PR 19906