Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fold back in getGroupACLs #19882

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Fold back in getGroupACLs #19882

merged 1 commit into from
Mar 24, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Mar 24, 2021 •
edited
Loading

Overview

Fold back in getGroupACLs

Moves the contents of a protected function into the function that calls it,

Before

Separate function, hard to follow

After

Easier to cleanup

Technical Details

Comments

@civibot
Copy link

civibot bot commented Mar 24, 2021

(Standard links)

@civibot civibot bot added the master label Mar 24, 2021
@seamuslee001
Copy link
Contributor

test fail unrelated merging

@seamuslee001 seamuslee001 merged commit 3edc596 into civicrm:master Mar 24, 2021
@seamuslee001 seamuslee001 deleted the acl_role branch March 24, 2021 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001