dev/financial#171 - Don't pass already formatted data to crmMoney on contact summary for custom fields

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/financial/-/issues/171

Passing already formatted data to crmMoney gives a false warning about a missing INTL because it also checks if the input is non-numeric. If you have a custom field of type money dropdown with a currency symbol included in the option choice labels it triggers this.

Before

warning

After

No warning, but now if you have a money text field the currency symbol no longer displays. But at the same time, this also "fixes" some double decimal separator replacement I was seeing a while ago and didn't know where it was coming from. i.e. 12,34 (US 12.34) would get displayed as 12 34 (thousands separator here was a space).

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

thanks for the sleuthing @demeritcowboy