dev/financial#171 - Don't

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/financial/-/issues/171

Before

Does

After

Doesn't

Technical Details

It's about money. The term markup can apply to the price of things. That's normal business, but it seems to be confused here with hypertext markup (html).

That's meant to be a pun - maybe a bit too involved.

Comments

This is a pretty generic form, so it may cause some fields to no longer display currency symbols or convert decimal separators.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I think we need to merge this since it's clearly wrong to pass html to the money format function & it should be formatted in the assigned html. I can that IS the case in the membership type form which uses this. We probably need to keep digging to find possible other places

The extra @mattwire added was 'Towards supporting EntityForm for 'View Action'

@mattwire can you identify any forms that implement that we can follow up & find a correct fix for money formatting for them 48c242d

[eileenmcnaughton]

Merging per above but we need to look for possible fall out from this & the previous change in the 6 weeks before release

[mattwire]

@eileenmcnaughton I don't remember this well but looks like it was to handle inconsistencies with the way "formatted" values are passed to the form. Agree it needs cleaning up.

[eileenmcnaughton]

@mattwire well if you can think of what to test...