Return from getACLRoles when contactID is not null

[eileenmcnaughton]

Overview

Return empty array from getACLRoles when contactID is null

This one line patch is the thinking part of cleaning up this function - ie it involves reading through the code & figuring out why the query doesn't make sense / will never return anything if contact_id is not empty.

Before

getACLRoles always returns empty when $contact_id is not NULL - but it hurts our brains

Basically the where is

WHERE acl.entity_table='civicrm_acl_role'....

if contact_id is set it becomes

AND acl.entity_table = 'civicrm_contact'

Which means that it would only ever return empty results

After

getACLRoles always returns empty when $contact_id is not NULL - but with less pain

Technical Details

I've made this patch the least possible code wise to allow brain space to think about the query....

(once this is merged more cleanup can happen but I wanted to
make this change easy to think through)

Comments

@colemanw @seamuslee001 this really is the state of the acl code - it's mad

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@eileenmcnaughton I agree with your thinking about what happens but I think its problematic but that should be addressed in a separate PR MOP

[eileenmcnaughton]

@seamuslee001 spoiler alert - the whole function does nothing

[eileenmcnaughton]

This #19872 is a bit like turning to the last page