Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - remove extra irrelevant fields from bridge joins #19868

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

colemanw
Copy link
Member

Overview

Removes a few confusingly redundant fields from searchKit when using a bridge join.

Before

Search for: Contacts
With: Related Contacts
Where: (notice that contact A display name and contact B display names are options in the list)

After

Redundant options gone

Technical Details

Those fields are redundant and would have caused unnecessary extra joins to be added to the query.

@civibot
Copy link

civibot bot commented Mar 22, 2021

(Standard links)

@civibot civibot bot added the master label Mar 22, 2021
@eileenmcnaughton
Copy link
Contributor

OK - I can see that there are 4 display name variants without this & 2 with it - so makes sense

@eileenmcnaughton eileenmcnaughton merged commit 71208a2 into civicrm:master Mar 23, 2021
@eileenmcnaughton eileenmcnaughton deleted the searchKitFixExtraFields branch March 23, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants