Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexmailer - Enable traditional mailing support by default #19863

Merged
merged 2 commits into from
Mar 27, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Switches to defaulting to flexmailer, if enabled.

This should be merged in conjunction with #19806
in order to keep those on the default in consistent state
(ie they will already be getting display-rendering for custom fields
and that will still be the case if 19806 is merged)

Before

If not otherwise set flexmailer defaults to using Mailing_BAO classes

After

If not otherwise set flexmailer defaults to flexmailer class

Technical Details

Step towards only having one code path to maintain

Comments

Switches to defaulting to flexmailer, if enabled.

This should be merged in conjunction with civicrm#19806
in order to keep those on the default in consistent state
(ie they will already be getting display-rendering for custom fields
and that will still be the case if 19806 is merged)
@civibot
Copy link

civibot bot commented Mar 22, 2021

(Standard links)

@civibot civibot bot added the master label Mar 22, 2021
@totten
Copy link
Member

totten commented Mar 23, 2021

This is a good idea and agree with linking it to #19806.

One small observation - the idea behind default=>auto is that the sysadmin specifically defers to upstream. I used this pattern because I expected we would want to flip the default at some point. Right now, the effective interpretation of auto is "Use bao". But we could change it to mean "use flexmailer".

If the only concern is new installations, then default=>flexmailer and default=>auto[aka flexmailer] are the same. The difference is for existing sites that are aligned with the default. (You might call these agnostic configurations.) Depending on utter happenstance, some agnostics have blank/omitted civicrm_setting (ie they track the metadata-default) while others have civicrm_setting persisted with the old default (so they don't track metadata-default).

IMHO, default=>flexmailer maybe makes sense if the intent is to leave some agnostics on bao. But if the idea is to flip all agnostics to flexmailer, then default=>auto[aka flexmailer] would be more effective.

@eileenmcnaughton
Copy link
Contributor Author

@totten OK - I think switching auto over makes more sense - where would we make that change

@totten
Copy link
Member

totten commented Mar 27, 2021

@eileenmcnaughton Since we've merged the token fix, I've pushed up the revision for how to flip the interpretation of auto.

@eileenmcnaughton
Copy link
Contributor Author

Looks good - this is now Tim's change & I am the review so MOP

@seamuslee001 seamuslee001 merged commit 294a4d8 into civicrm:master Mar 27, 2021
@seamuslee001 seamuslee001 deleted the flex branch March 27, 2021 04:40
@totten totten changed the title Update flexmailer default Flexmailer - Enable traditional mailing support by default Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants