Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Fix test failures on PHP 7.4 caused by either NULL being set fo… #19849

Merged

Conversation

seamuslee001
Copy link
Contributor

…r the membership_type_id or Payment Processor not being set on the form

Overview

This fixes 2 test failures on PHP 7.4 as per title

Before

Tests fail

          <error type="PHPUnit\Framework\Error\Notice">CRM_Event_Form_ParticipantTest::testSubmitUnpaidPriceChangeWhileStillPending
Trying to access array offset on value of type null

/home/jenkins/bknix-edge/build/build-2/web/sites/all/modules/civicrm/CRM/Contribute/Form/AbstractEditPayment.php:695

            <error type="PHPUnit\Framework\Error\Notice">CRM_Member_Form_MembershipTest::testSubmitRecurTwoRows
Trying to access array offset on value of type null

/home/jenkins/bknix-edge/build/build-2/web/sites/all/modules/civicrm/CRM/Member/Form.php:500

After

Tests pass

ping @eileenmcnaughton

…r the membership_type_id or Payment Processor not being set on the form
@civibot
Copy link

civibot bot commented Mar 19, 2021

(Standard links)

@civibot civibot bot added the master label Mar 19, 2021
@seamuslee001 seamuslee001 merged commit a101220 into civicrm:master Mar 20, 2021
@seamuslee001 seamuslee001 deleted the member_event_form_test_fixes branch March 20, 2021 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants