Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Fix PHP 7.4 errors on ContributionPage tests #19846

Merged

Conversation

seamuslee001
Copy link
Contributor

Overview

This fixes 2 test failures when running the unit tests on PHP 7.4

Before

Tests fail

          <error type="PHPUnit\Framework\Error\Notice">CRM_Contribute_Form_Contribution_ConfirmTest::testPayNowPayment
Trying to access array offset on value of type null

/home/jenkins/bknix-edge/build/build-2/web/sites/all/modules/civicrm/CRM/Contribute/Form/Contribution/Confirm.php:2718


          <error type="PHPUnit\Framework\Error\Notice">CRM_Contribute_Form_Contribution_ThankYouTest::testLiveAndTestContributionStatus
Trying to access array offset on value of type null

/home/jenkins/bknix-edge/build/build-2/web/sites/all/modules/civicrm/CRM/Contribute/Form/Contribution/ThankYou.php:183

After

Tests pass

ping @eileenmcnaughton

@civibot
Copy link

civibot bot commented Mar 19, 2021

(Standard links)

@seamuslee001
Copy link
Contributor Author

Test fail unrelated

@seamuslee001 seamuslee001 merged commit 966e6a6 into civicrm:master Mar 19, 2021
@seamuslee001 seamuslee001 deleted the fix_contribution_page_tests branch March 19, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants