Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Fix Membership Type Test error on php7.4 #19845

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

seamuslee001
Copy link
Contributor

Overview

This fixes a test failure on the MembershipType Test suite on PHP 7.4 caused by trying to do array access on value of type int

Before

Test fails on PHP 7.4

<error type="PHPUnit\Framework\Error\Notice">api_v3_MembershipTypeTest::testEnableMembershipTypeOnContributionPage
Trying to access array offset on value of type int

**/home/jenkins/bknix-edge/build/build-2/web/sites/all/modules/civicrm/tests/phpunit/api/v3/MembershipTypeTest.php:326**

After

Test passes

ping @eileenmcnaughton

@civibot
Copy link

civibot bot commented Mar 19, 2021

(Standard links)

@civibot civibot bot added the master label Mar 19, 2021
@seamuslee001 seamuslee001 merged commit 5f0a297 into civicrm:master Mar 19, 2021
@seamuslee001 seamuslee001 deleted the fix_membership_type_test branch March 19, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants