Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade angularJs from 1.8.0 to 1.8.2 #19831

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Mar 18, 2021

Overview

Per https://lab.civicrm.org/dev/core/-/issues/1818
this gives a minor version bump to the AngularJS library.

Before

1.8.0

After

1.8.2

Notes

According to the release notes there are no breaking changes in this upgrade.

@civibot
Copy link

civibot bot commented Mar 18, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor

Good timing since we are actively hammering the angular forms in dev and on the rc we should pick up any weirdness (angular updates have been safe in the past)

@eileenmcnaughton eileenmcnaughton merged commit 48ddc5c into civicrm:master Mar 18, 2021
@eileenmcnaughton eileenmcnaughton deleted the angularUpgrade branch March 18, 2021 22:07
@@ -4,7 +4,7 @@
"Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
"This file is @generated automatically"
],
"content-hash": "2d1dfc8bddd169a9064a89c693bb5218",
"content-hash": "ec5c7533d5c9d49d54530eb94958e55b",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this content hash correct? I'm getting a warning about composer.lock being out of date and you can see the same message on PR test console logs. When I try to update it it also seems to remove a whole bunch of other stuff but I'm not sure if it should or not.

I also get a message License "AGPL-3.0" is a deprecated SPDX license identifier, use "AGPL-3.0-only" or "AGPL-3.0-or-later" instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants