APIv4 - Use subquery to LEFT JOIN via a bridge entity

[colemanw]

Overview

Per https://lab.civicrm.org/dev/core/-/issues/2438

Fixes the ability to do "Without" conditions in SearchKit when a bridge table is used (e.g. EntityTag or RelationshipCache).

Before

Bridge entities are supposed to be transparent in APIv4, but when LEFT joining, an artifact of the double-join would give extraneous results.

After

Uses a subquery to achieve a single LEFT JOIN making the bridge table invisible to the api user.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@colemanw so I shouldn't test this until you have added another commit?

[colemanw]

I just pushed up a new feature into this PR where you can select "Without" as a join type in SearchKit. I'll add another commit soon with a test and an upgrade script, but feel free to do an r-run at this point :)

[eileenmcnaughton]

OK - I had a bit of trouble testing this but there reasons were in the end UI issues unrelated to this PR - e.g inadvertently selecting the tag id from the first join in the second join

[eileenmcnaughton]

So my upgrade test passed this time

Before

{"version":4,"select":["id","display_name"],"orderBy":[],"where":[],"groupBy":[],"join":[["Contribution AS Contact_Contribution_contact_id_01",true,["id","=","Contact_Contribution_contact_id_01.contact_id"]]],"having":[]}

After

{"version":4,"select":["id","display_name"],"orderBy":[],"where":[],"groupBy":[],"join":[["Contribution AS Contact_Contribution_contact_id_01","INNER",["id","=","Contact_Contribution_contact_id_01.contact_id"]]],"having":[]}

One thing I would note is we should probably make extension upgrades visible to run from the civicrm/upgrade screen or run automatically as I rather failed to spot that I needed a separate process

MOP