Fixed issue dev/core#2449: remove an unnecessary call to cleanMoney #19807
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes an unnecessary call to
CRM_Utils_Rule::cleanMoney
Before
When your locaization settings decimal separator where set to
,
and you had a contribution page with an amount of12,987654321
it resulted in paying a wrong amount.After
Through the contribution page the right amount is paid.
Technical Details
The call to
CRM_Utils_Rule::cleanMoney
is removed which was at a weird place. We should sanitize/validate/clean user input early.Comments
See https://lab.civicrm.org/dev/core/-/issues/2449