Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue dev/core#2449: remove an unnecessary call to cleanMoney #19807

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

jaapjansma
Copy link
Contributor

Overview

Removes an unnecessary call to CRM_Utils_Rule::cleanMoney

Before

When your locaization settings decimal separator where set to , and you had a contribution page with an amount of 12,987654321 it resulted in paying a wrong amount.

After

Through the contribution page the right amount is paid.

Technical Details

The call to CRM_Utils_Rule::cleanMoney is removed which was at a weird place. We should sanitize/validate/clean user input early.

Comments

See https://lab.civicrm.org/dev/core/-/issues/2449

@civibot
Copy link

civibot bot commented Mar 15, 2021

(Standard links)

@civibot civibot bot added the master label Mar 15, 2021
@eileenmcnaughton
Copy link
Contributor

Thanks @jaapjansma - merging this as already discussed. Per the code comment the line was wrong in terms of our expected flow but now @jaapjansma has confirmed that it does actual harm so removing is correct

@eileenmcnaughton eileenmcnaughton merged commit 0dc105e into civicrm:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants