core#2461 - allow booleans to be of type boolean

[MegaphoneJon]

https://lab.civicrm.org/dev/core/-/issues/2461

Overview

The regex match for validating booleans assumes you're passing a string. With APIv4 we're also passing booleans. Since the tested value is implicitly cast to a string, TRUE passes but FALSE doesn't

Before

Passing the value FALSE doesn't pass validation. If you're using the API, this returns an exception.

After

FALSE is acceptable as a boolean value.

Technical Details

php > $temp = (string) TRUE;
php > echo $temp;                                                                                                                                                                                                                             
1
php > $temp = (string) FALSE;                                                                                                                                                                                                            
php > echo $temp;                                                                                                                                                                                                                             
php > 

Comments

I wrote tests on CRM_Utils_Type::escape() and CRM_Utils_Rule::boolean() while I was still puzzling through this. They're not both necessary, but who's going to turn down extra (passing) tests?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Nice sleuthing!

[demeritcowboy]

Nice.

What locale do the tests run under - in North America at least most people under 70 have only ever seen Cavendish bananas, which most banana connoisseurs generally consider FALSE, but it wouldn't surprise me if in some locales the local banana is TRUE. Needs (taste) test.

(grin)

[seamuslee001]

Jenkins re test this please