[REF] Cleanup on permission code

[eileenmcnaughton]

Overview

[REF] Cleanup on permission code

Before

Ug

After

Soothing calm

Technical Details

The function returns either an array of arrays or an array of the
first key in the array, depending on the 'desriptions' parameter.

This cleans it up so that instead of handling the descriptions
parameter in multiple places we get the array
in all cases and do the formatting at the end

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@colemanw can you merge this so I can simplify the super-duper PR? (Should help people looking at it / discussing)

[colemanw]

Yes. Refactor looks sensible & tests pass.