dev/core#2459 Fix custom fields changed from multiple-choice data type to Text #19794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
reviewed
Mar 13, 2021
| @@ -1994,6 +1994,11 @@ protected static function prepareCreate($params) { | |||
| } | |||
| } | |||
|
|
|||
| // Remove option group IDs from fields changed to Text html_type. | |||
| if ($htmlType == 'Text') { | |||
There was a problem hiding this comment.
This is a good change. Are there other html types this should also apply to?
|
I'm going to merge this as it makes sense as is and I don't think it should be blocked on @colemanw's question about whether the scope is broad enough @MegaphoneJon please consider the comment & if you still this goes far enough please close out the gitlab |
|
@colemanw There aren't other HTML types where this should happen. Every data type that allows an option group (String, Int, Float, Money) has HTML types that require an option group or are "Text". Now, if I ever get around to implementing that "Hidden" HTML type I've been toying with, that'd be a different story... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://lab.civicrm.org/dev/core/-/issues/2459
Overview
Changing a custom field from a multiple choice (Radio, Checkboxes, etc.) to a free-entry text box works, until you try to write to the custom field via the API.
Reproduction steps are on the ticket.
Before
API Error - your value isn't an accepted value for this field.
After
A custom field with a data type of "String" and HTML type of "Text" should take any alphanumeric value.
Technical Details
Changing the HTML type doesn't remove the Option Group ID. While arguably the API code should ignore that, it seems more important that the data be correct.