[REF] getCorePermissions cleanup #19789
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Before
administer multiple organizations set up differently to all the other core permissions
Parameter passed to getCorePermissions even though the function signaure does not accept one
After
poof
Technical Details
I'm pretty sure this is just 'I don't want to touch it' that led to this permission being different. Either it's in core & is a core permission & should be subject to the same formatting etc or it should be moved to the multisite extension - while I can see the appeal of the latter it might be too big a lift for right now.
I need to rationalise getCorePermissions vs getBasicPermissions in order to extend the implied permissions concept
Comments
@seamuslee001