Remove unused variables/assigns from buildMembershipBlock function

[mattwire]

Overview

Further simplification of the buildMembershipBlock() function that was moved from contributionBase.

This removes an unused assign and variables from the Confirm and ThankYou pages.

Before

Unused variable assigned

After

Unused variable not assigned or created.

Technical Details

allowAutoRenewMembership is used in Main.tpl and MembershipBlock.tpl. Only MembershipBlock.tpl is included from Confirm.tpl and ThankYou.tpl.
If you look here https://github.com/civicrm/civicrm-core/blob/master/templates/CRM/Contribute/Form/Contribution/MembershipBlock.tpl#L274 you can see that allowAutoRenewMembership is used in an if statement that makes no sense for Confirm/ThankYou pages because it's setting the status of a checkbox that doesn't exist.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

OK - I agree with the case you are making here