Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect placeholder text on 'Create Campaign' form #19767

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Mar 9, 2021

Overview

Fixes some incorrect placeholder text on the form to create/edit a campaign, for the select fields "Campaign Type" and "Campaign Status"

Before

image

After

image

@civibot
Copy link

civibot bot commented Mar 9, 2021

(Standard links)

@civibot civibot bot added the master label Mar 9, 2021
@colemanw
Copy link
Member Author

colemanw commented Mar 9, 2021

@agh1 I think this might be related to some work you did fixing placeholders for accessibility.

@demeritcowboy
Copy link
Contributor

@demeritcowboy
Copy link
Contributor

This works for me.

As noted in the ticket this also happens with grants, but doesn't come up in other places because the field is usually required. Just oddly for the grants page it's required and also shows a placeholder.

@demeritcowboy
Copy link
Contributor

Grants PR: #19768

@eileenmcnaughton
Copy link
Contributor

merging based on @demeritcowboy review

@eileenmcnaughton eileenmcnaughton merged commit d35291a into civicrm:master Mar 10, 2021
@eileenmcnaughton eileenmcnaughton deleted the campaignPlaceholders branch March 10, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants