[REF] Minor simplification around assigning taxAmount to the template #19757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
Just assign it based on the calculated tax amount for the contribution. If no tax then just assign that to the tpl. Bye copy & paste
d5d1dca to
4d540f3
Compare
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Mar 22, 2021
Rather than rely on these being passed around retrieve them with a consistent function. Note tax_amount is retrieved one other place but that is fixed in civicrm#19757 Line item will be used less once civicrm#19801 is merged
|
@colemanw less important to the cleanup but this one is really simple... |
|
Well the after code certainly makes a lot more sense! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Minor simplification around assigning taxAmount to the template
Before
A bunch of confusing code
After
Just assign it based on the calculated tax amount for the contribution. If no tax then
just assign that to the tpl. Bye copy & paste
Technical Details
Comments