Export UI - Only present "save mapping" button to permissioned users #19733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The button was showing for all users which would result in confusion when it didn't work because they lacked permission. Currently the APIv3 Mapping.create api requires "administer CiviCRM." I don't know if that's right or if there's another permission it ought to be checking, but at least this brings the UI in alignment with what's currently allowed.
|
(Standard links)
|
|
Merging based on review & testing in GL. |
|
Yep - testing is appropriate to this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The button was showing for all users which would result in confusion when it didn't work because they lacked permission.
See https://lab.civicrm.org/dev/core/-/issues/2435
Before
Button shows for all users, then fails to work.
After
Button hidden for non-admins.
Comments
Currently the APIv3 Mapping.create api requires "administer CiviCRM." I don't know if that's right or if there's another
permission it ought to be checking, but at least this brings the UI in alignment with what's currently allowed.