Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ts() namespace in searchKit & afform extensions #19729

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Mar 4, 2021

Overview

Ensures all translatable strings in SearchKit & Afform extensions are translated using the extension namespace.

Before

Translatable strings not namespaced.

After

Fixed.

Comments

Also a little minor code cleanup in this PR.

@civibot
Copy link

civibot bot commented Mar 4, 2021

(Standard links)

@civibot civibot bot added the master label Mar 4, 2021
@mlutfy
Copy link
Member

mlutfy commented Mar 4, 2021

Cross-referencing previous discussions on core-ext gettext namespacing/domains:
https://lab.civicrm.org/dev/translation/-/issues/52

I'm 👍 on merging this.

@colemanw colemanw added the merge ready PR will be merged after a few days if there are no objections label Mar 6, 2021
@colemanw
Copy link
Member Author

colemanw commented Mar 6, 2021

Sounds like this is merge-ready.

@seamuslee001
Copy link
Contributor

@colemanw can you please rebase this?

@mlutfy
Copy link
Member

mlutfy commented Mar 8, 2021

jenkins, test this please

api_v3_SyntaxConformanceTest::testCreateSingleValueAlter with data set #82 ('UFField')
Failure in api call for UFField create:  Undefined index: type

@colemanw
Copy link
Member Author

colemanw commented Mar 8, 2021

That's an unrelated fail that happens from time to time.

@mlutfy mlutfy merged commit cfbf775 into civicrm:master Mar 8, 2021
@mlutfy
Copy link
Member

mlutfy commented Mar 8, 2021

yay 🎉 thanks @colemanw

@colemanw colemanw deleted the coreExtCleanup branch September 27, 2021 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants