dev/core#2422 Add created_id, modified_id, expires_date to saved search table #19709
Conversation
|
(Standard links)
|
9a44022 to
0d04d94
Compare
|
@eileenmcnaughton It seems to me if we are adding |
|
@mattwire I did consider those - I'm happy to add them in if you want me to (I wavered because they aren't in the civicrm_group table yet I think) |
|
I think it would be good. I've generally found wherever we're recording a create/modify contact_id the date is useful too. |
|
@mattwire ok - I've added them in |
|
I haven't |
|
after spending more time playing with saved search I think we also want a description field to elaborate on what the searches are (also in the group table). I realise my biggest challenge now is getting this through review so not sure whether to attempt to add that or wait for this to hopefully get merged |
|
I'm happy to merge this after you add a description field @eileenmcnaughton |
…ch table Per https://lab.civicrm.org/dev/core/-/issues/2422 These can be exposed in the search kit saved search listing as filters when we get to that point but the earlier we start saving them the better the data will be when we do expose
|
@colemanw should I go whole hog & add frontend_description per Group.xml |
|
Well I've added in description now |
|
|
||
| /** | ||
| * When the search was lase modified. | ||
| * |
CRM/Contact/DAO/SavedSearch.php
Outdated
| 'name' => 'modified_date', | ||
| 'type' => CRM_Utils_Type::T_TIMESTAMP, | ||
| 'title' => ts('Modified Date'), | ||
| 'description' => ts('When the search was lase modified.'), |
There was a problem hiding this comment.
This one is actually supposed to be modified with lasers.
There was a problem hiding this comment.
I dunno if we should add lasers as a hard-dependency. We want to support older systems that don't have built-in CD burners. IMO Civi should work on any box fast enough to run Win95.
There was a problem hiding this comment.
OK - you had your fun - all lasers updated now
xml/schema/Contact/SavedSearch.xml
Outdated
| <field> | ||
| <name>modified_date</name> | ||
| <type>timestamp</type> | ||
| <comment>When the search was lase modified.</comment> |
There was a problem hiding this comment.
Typo: "lase"
At least it's consistent!
I wouldn't, no. SavedSearches are a backend thing. SearchDisplays are more front-endey. |
|
@colemanw all passing now without the lasers |
Overview
Per https://lab.civicrm.org/dev/core/-/issues/2422 sites using search kit will rapidly start to accumulate a large number of saved searches and will want better filtering (& cleanup). This adds created_id and modified_id and starts populating them as well as expires_date (which won't start populating until we expose it in the search kit UI).
Starting to populate this data in 5.36 (before we've had a chance to expose it) means that when we do people will see data not just empty fields.
Before
id of saved_search creator / modifier not stored. No field for expires_date
After
tada
Technical Details
@colemanw
Comments