Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix master-only regression #19667

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Fix master-only regression #19667

merged 1 commit into from
Feb 25, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Feb 24, 2021 •
edited
Loading

It seems the tests ran before the test that covered this
was merged giving a false positive

See #19478 (comment) for rationale

@demeritcowboy

@eileenmcnaughton
Fix master-only regression
44e2789 
It seems the tests ran before the test that covered this
was merged giving a false positive

See civicrm#19478 (comment) for rationale
@civibot
Copy link

civibot bot commented Feb 24, 2021

(Standard links)

@civibot civibot bot added the master label Feb 24, 2021
@eileenmcnaughton eileenmcnaughton mentioned this pull request Feb 24, 2021
Merged
@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton eileenmcnaughton mentioned this pull request Feb 24, 2021
Merged
@demeritcowboy
Copy link
Contributor

Looks good.

@seamuslee001
Copy link
Contributor

Merging as per @demeritcowboy

@seamuslee001 seamuslee001 merged commit 328742b into civicrm:master Feb 25, 2021
@seamuslee001 seamuslee001 deleted the recurse branch February 25, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @demeritcowboy @seamuslee001