Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata - Add 'readonly' to id fields, custom fields & contact fields #19627

Merged
merged 3 commits into from
Feb 19, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Feb 18, 2021

Overview

Adds 'readonly' metadata to all id fields, custom fields with 'is_view' and appropriate contact fields.

See https://lab.civicrm.org/dev/core/-/issues/2397

Before

Schema had no way to identify fields as 'readonly'.

After

Now it does.

Technical Details

For core fields, applies to primaryKey fields and fields tagged <readonly>.
For custom fields, this comes through via the 'is_view' property.

This will help autogenerated forms to know whether a field is appropriate to show to the user.

For core fields, applies to primaryKey fields and fields tagged <readonly>.
For custom fields, this comes through via the 'is_view' property.

This will help autogenerated forms to know whether a field is appropriate to show to the user.
@civibot
Copy link

civibot bot commented Feb 18, 2021

(Standard links)

@civibot civibot bot added the master label Feb 18, 2021
@colemanw colemanw changed the title dev/core#2397 Add 'readonly' to id fields, custom fields & contact fields Metadata - Add 'readonly' to id fields, custom fields & contact fields Feb 18, 2021
@seamuslee001
Copy link
Contributor

This seems to be ok to me and the premise makes sense, I would also add this is adding a piece of new metadata to the DAOs and there for apiv3 is not impacted nor the standard DAO functionality and unit tests have passed so merging

@seamuslee001 seamuslee001 merged commit b8449b8 into civicrm:master Feb 19, 2021
@seamuslee001 seamuslee001 deleted the readonly branch February 19, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants