Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty {ts} #19622

Merged

Conversation

demeritcowboy
Copy link
Contributor

Overview

While there might be some exceptional times to use {ts} against just a variable and no actual text, this doesn't seem to be one of them. Use ts() or E::ts() in the original settings['description'] definition where the actual words are.

Before

There's nothing to extract for translators to translate here.

After

Use ts() or E::ts() where the description text is defined.

Technical Details

Comments

See also https://docs.civicrm.org/dev/en/latest/translation/#ensure-that-strings-have-some-words-in-them

@civibot
Copy link

civibot bot commented Feb 17, 2021

(Standard links)

@civibot civibot bot added the master label Feb 17, 2021
@seamuslee001
Copy link
Contributor

ping @eileenmcnaughton @mlutfy

@eileenmcnaughton
Copy link
Contributor

I agree this is the wrong place - are we doing it at the right place?

@demeritcowboy
Copy link
Contributor Author

For core yes. At the bottom of this link there's a slew of related PRs #16224

@eileenmcnaughton
Copy link
Contributor

@demeritcowboy OK - that looks right!

@eileenmcnaughton eileenmcnaughton merged commit 0bdeec7 into civicrm:master Feb 17, 2021
@demeritcowboy demeritcowboy deleted the setting-description-ts branch February 17, 2021 22:26
@demeritcowboy
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants