Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Fix array access on NULL error when running afform unit tests o… #19542

Merged
merged 1 commit into from
Feb 5, 2021
Merged

[REF] Fix array access on NULL error when running afform unit tests o… #19542

merged 1 commit into from
Feb 5, 2021

Conversation

seamuslee001
Copy link
Contributor

…n PHP 7.4

Overview

Fixes the following test fails on PHP7.4

  • api_v4_AfformUsageTest::testAboutMeAllowed
  • api_v4_AfformUsageTest::testAboutMeForbidden

Error is Trying to access array offset on value of type null

Before

Tests fail

After

Tests pass

ping @totten @eileenmcnaughton @colemanw

@civibot
Copy link

civibot bot commented Feb 5, 2021

(Standard links)

@civibot civibot bot added the master label Feb 5, 2021
@eileenmcnaughton
Copy link
Contributor

OK - I thought about a syntax variant but then thought 'let's not overthink this'

@eileenmcnaughton eileenmcnaughton merged commit e301787 into civicrm:master Feb 5, 2021
@eileenmcnaughton eileenmcnaughton deleted the afform_fix_array_access branch February 5, 2021 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seamuslee001 @eileenmcnaughton