APIv4 - Fix HTTP status code selection

[totten]

This is a follow-up to #19526 which addresses a typo that causes a misbehavior in reporting the HTTP status code.

Before

If an API request encounters an exception, then it always returns HTTP 403.

After

If an API request encounters an exception, then:

• It may return HTTP 403 (for an authorization exception)
• It may return HTTP 500 (for any other/unrecognized exception)

Comments

To test this, I just hacked an API locally and then ran it via curl or Firefox:

diff --git a/Civi/Api4/Entity.php b/Civi/Api4/Entity.php
index 5689252494..8aee88f04e 100644
--- a/Civi/Api4/Entity.php
+++ b/Civi/Api4/Entity.php
@@ -33,6 +33,8 @@ class Entity extends Generic\AbstractEntity {
    * @return Action\Entity\Get
    */
   public static function get($checkPermissions = TRUE) {
+//A//    throw new \Exception('asdfasdf');
+//B//    throw new \Civi\API\Exception\UnauthorizedException('fdsa');
     return (new Action\Entity\Get('Entity', __FUNCTION__))
       ->setCheckPermissions($checkPermissions);
   }

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Looks good.