Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Further extract the portion of sendTemplate that relates to rendering #19522

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

eileenmcnaughton
Copy link
Contributor


Overview

[REF] Further extract the portion of sendTemplate that relates to rendering

Before

Rendering functionality in the main code block

After

Functionality in it's own function, required inputs (at this stage) are clear.

Technical Details

This is primary for the purposes of simplification at this stage so the function is protected. It might make sense to make it public in the near future and directly add test cover

Comments

…dering

This is primary for the purposes of simplification at this stage
@civibot
Copy link

civibot bot commented Feb 4, 2021

(Standard links)

@civibot civibot bot added the master label Feb 4, 2021
@mattwire mattwire merged commit 7cbe37b into civicrm:master Feb 4, 2021
@mattwire
Copy link
Contributor

mattwire commented Feb 4, 2021

Thanks @eileenmcnaughton makes it much clearer. I think we should keep it protected for now because I think we might want to change the inputs and/or name once we work out what we're doing with enhancements to token processing / rendering.

@eileenmcnaughton eileenmcnaughton deleted the ref_template branch February 4, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants