Move require once in api kernel to support edge cases #19513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function 'createError' on the kernel class calls 3 functions that are in the api v3 utils file. It is possible to reach this from apiv4 using drush (I realise we don't really know much about how to support api v4 with drush but it DOES work with a simple api with this patch in my testing). We could go with only including utils.php in v4 api AND the createError function. I think it's more readable this way. To test this try drush cvapi Contribution.get version=4 it will legitimately fail without checkPermissions=0 but it will fail with a require_once error without this patch
|
(Standard links)
|
|
test this please |
|
This looks correct to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Move require once in api kernel to support edge cases
Before
fails with a require_once error
After
Above fails (correctly) with a permissions error
Technical Details
The function 'createError' on the kernel class calls 3 functions that are in the api v3 utils file.
It is possible to reach this from apiv4 using drush (I realise we
don't really know much about how to support api v4 with drush but it DOES work with a simple
api with this patch in my testing). We could go with only including utils.php in
v4 api AND the createError function. I think it's more readable this way.
To test this try
drush cvapi Contribution.get version=4
it will legitimately fail without checkPermissions=0 but it will fail with a
require_once error without this patch
Comments