Use exceptions when enabling case component / checking for 'CREATE VIEW' permissions #19503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
See #18466. This removes another use of
ignoreException()
. In this case thecivicrm/admin/setting/component
form was hanging becauseignoreException()
was not enabled and the DB error exception was not trapped. This fixes that and removes ignoreException() from the enable case function.To test, remove "CREATE VIEW" permission from your mysql user. It is clear from the comments that this code was never working very well.
Before
ignoreException()
used when testing for/creating views.After
Exceptions thrown and feedback provided to user.
Technical Details
Explained above.
Comments
@seamuslee001 @eileenmcnaughton