Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exceptions when enabling case component / checking for 'CREATE VIEW' permissions #19503

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented Feb 2, 2021

Overview

See #18466. This removes another use of ignoreException(). In this case the civicrm/admin/setting/component form was hanging because ignoreException() was not enabled and the DB error exception was not trapped. This fixes that and removes ignoreException() from the enable case function.

To test, remove "CREATE VIEW" permission from your mysql user. It is clear from the comments that this code was never working very well.

Before

ignoreException() used when testing for/creating views.

After

Exceptions thrown and feedback provided to user.

Technical Details

Explained above.

Comments

@seamuslee001 @eileenmcnaughton

@civibot
Copy link

civibot bot commented Feb 2, 2021

(Standard links)

@civibot civibot bot added the master label Feb 2, 2021
@seamuslee001
Copy link
Contributor

Makes sense to me

@seamuslee001 seamuslee001 merged commit 9044fe6 into civicrm:master Feb 2, 2021
@eileenmcnaughton
Copy link
Contributor

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants