Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2352: fix Views integration suggestion #19491

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Issue #2352: fix Views integration suggestion #19491

merged 1 commit into from
Feb 1, 2021

Conversation

herbdool
Copy link
Contributor

@herbdool herbdool commented Feb 1, 2021

Overview

Fixes https://lab.civicrm.org/dev/core/-/issues/2352

Excludes backticks if userFramework is Backdrop.

@civibot
Copy link

civibot bot commented Feb 1, 2021

(Standard links)

@civibot civibot bot added the master label Feb 1, 2021
@eileenmcnaughton
Copy link
Contributor

Test fails not related - impacting others. Generally we try to call a function on the uf class rather than check which one it is in the code - but this is also pretty trivial & would probably require more of a rethink that we might want to punt on - merging

@eileenmcnaughton eileenmcnaughton merged commit d85bf74 into civicrm:master Feb 1, 2021
@herbdool
Copy link
Contributor Author

herbdool commented Feb 2, 2021

I agree that's a better approach but looks like this whole part needs to be refactored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants