Search Kit - Fix display pager and improve error handling #19479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
test this please |
|
This is now displaying the pager on the table display and in the dashlet. The preview button on the edit table display is still not paging correctly - see https://lab.civicrm.org/dev/core/-/issues/2347 This can be merged as it improves |
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes missing Search Kit display pagers, and avoids a crash when processing an afform with missing entities.
Before
Pager missing from search displays, possible crash if a search display is embedded in afform dashlet and then search kit extension is disabled.
After
Pager fixed.
Afform error logged instead of crashing site.