NFC Minor code cleanup to contribution pages

[mattwire]

Overview

Just some minor cleanups.

Before

After

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Civi\Financialacls\BuildAmountHookTest::testBuildAmount
Failed asserting that actual size 2 matches expected size 1.

/home/jenkins/bknix-dfl/build/core-19468-621c8/web/sites/all/modules/civicrm/ext/financialacls/tests/phpunit/Civi/Financialacls/BuildAmountHookTest.php:40
/home/jenkins/bknix-dfl/extern/phpunit6/phpunit6.phar:570

[eileenmcnaughton]

My understanding is that ccid in the url is an option if you are making a payment against an existing contribution (personally I'd rather see us expose the add payment form but it's complicated..... & the contribution pages are crazy overloaded in general)

Anyway - rather than using a straight getter I'd go for a descriptive function ie

public function isPaymentAgainstExistingContribution() to be accessed from the form rule

[mattwire]

@demeritcowboy @eileenmcnaughton Thanks for reviewing. I've changed _ccid to public. Adding a getter in this PR is a step too far as this was just about understanding what that param was rather than actually doing any cleanup/refactoring.

[eileenmcnaughton]

OK - looks good now