Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/translation#64 - Using %1%2 seems to confuse transifex - System status check Cms.php #19453

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

demeritcowboy
Copy link
Contributor

Overview

https://lab.civicrm.org/dev/translation/-/issues/64

The string to translate appears a bit garbled in transifex since the 2 ends up part of the string to be translated. In any case there doesn't appear to be a need for a %2.

Before

The literal 2 is part of the string to be translated.

After

As intended.

Technical Details

Comments

I can't personally confirm this fixes it since I don't use transifex. Am going on what was reported at https://chat.civicrm.org/civicrm/pl/xs88zzbksjn53jyhnprzmaacte

@civibot
Copy link

civibot bot commented Jan 27, 2021

(Standard links)

@civibot civibot bot added the master label Jan 27, 2021
@colemanw
Copy link
Member

Looks great.

@mlutfy
Copy link
Member

mlutfy commented Jan 27, 2021

Indeed, it's an incorrect use of ts (it's not a concatenation function).

@seamuslee001 seamuslee001 merged commit e665e62 into civicrm:master Jan 27, 2021
@demeritcowboy demeritcowboy deleted the translate branch January 27, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants