Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Move sendNotification out of recur, remove unused related_contact #19443

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jan 25, 2021

Overview

[REF] Move sendNotification out of recur, remove unused related_contact

Before

Send notification in the recur function, needing extra ids to be passed into the function

After

Outside the function

Technical Details

We no longer use ids['related_contact'] & are attempting to simplify (& eventually remove
the ids variable). Note the surrounding if means it will only be called on specific trxn_types

Comments

@civibot
Copy link

civibot bot commented Jan 25, 2021

(Standard links)

@civibot civibot bot added the master label Jan 25, 2021
We no longer use ids['related_contact'] & are attempting to simplify (& eventually remove
the ids variable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants