dev/core#2327 - In the sample casetype xml files the <name> is the label not the name

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/2327

The <name> inside the file isn't used as much as I think it used to be. But you can see the effect for example when using the "Print Report" feature on manage case.

Probably quickest way to test is:
1. Copy one of the casetype files from CRM/Case/xml/configuration.sample into CRM/Case/xml/configuration
2. Create or visit a case of that type and then click Print Report.
3. Now visit a regular civi page like /civicrm/admin and you'll see a big red box with all the errors it generated.

Ok actually looking closer I can't see where it's used at all.

Before

label

After

name

Technical Details

name - label

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Hmm, no the red boxes are something else. I'm not sure anymore where this <name> is used.

[eileenmcnaughton]

OK - I think you have dug into this as much as makes sense - merging

[demeritcowboy]

Thanks I think it's the right thing regardless of whether it's used or not. I'm just getting more and more convinced it's not actually used anywhere anymore.