Fix rendering of Dashlet placeholder #19413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
reviewed
Jan 18, 2021
| @@ -91,7 +91,9 @@ fieldset.crm-inactive-dashlet-fieldset legend { | |||
| #civicrm-dashboard .ui-sortable-placeholder { | |||
| border: 2px dashed grey; | |||
| visibility: visible !important; | |||
| height: 80px !important; | |||
| width: 226px; | |||
There was a problem hiding this comment.
What's the significance of the number 226? This layout is fluid using flex css, so there aren't any fixed widths to speak of.
There was a problem hiding this comment.
The draggable items are 230px wide, so this sets the correct width of the placeholder, i.e. 230px - 4px border.
There was a problem hiding this comment.
Hence the 66px height too
|
Ok I agree this is an improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes this issue raised on Lab.
Before
Dragging a Dashlet in the Available Dashlets panel causes the layout to jump unexpectedly.
After
Dragging a Dashlet in the Available Dashlets panel does not cause the layout to jump unexpectedly.