dev/core#2303 Extract function to load the messageContent for a template

[eileenmcnaughton]

Overview

This is a fairly straightforward extraction, seeking to break down the very-busy sendtemplate function
into the sub-functions within it. Essentially we load the template content, we swap out the tokens
and we send it.

Note that I have added a parameter to the output sent to alterMailContent
of 'workflow_name' which is more accurate - I updated the docs

Before

Function part of metafunction

After

Extracted

Technical Details

Comments

It seems to have committed rather than PR-d my docs change
https://lab.civicrm.org/documentation/docs/dev/-/blob/master/docs/hooks/hook_civicrm_alterMailContent.md

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Looks like at least some of the test fails are related @eileenmcnaughton

[eileenmcnaughton]

Yep I didn't finish the isTest bit - trying again....

[mattwire]

@eileenmcnaughton Can you add a small description to the code + docs about what workflow_name actually means?

[eileenmcnaughton]

@mattwire OK I've put up a commit with some comments & also edited https://lab.civicrm.org/documentation/docs/dev/-/blob/master/docs/hooks/hook_civicrm_alterMailContent.md

[eileenmcnaughton]

Unrelated fail